Skip to content

Skip deprecation warnings bad request for Serverless or Environment providers #2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

Skip deprecation warnings bad request for Serverless or Environment providers #2514

merged 1 commit into from
Apr 7, 2025

Conversation

@mrodm
Copy link
Contributor

@mrodm mrodm commented Apr 3, 2025

This PR ignores or skip the deprecation warnings validation for Serverless and Environment providers.

In case of Serverless, it is skipped directly.
In case of the Environment provider, it is tried to validate the warnings. However, if the query returns status code 400 (Bad Request), the error is ignored.

Example of the error found in a Serverless project trying to run some system tests:

--- Test results for package: elastic_package_registry - START ---
╭──────────────────────────┬─────────────┬───────────┬───────────┬─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┬───────────────╮
│ PACKAGE                  │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT                                                                                                                                                                                                                                                                                          │  TIME ELAPSED │
├──────────────────────────┼─────────────┼───────────┼───────────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼───────────────┤
│ elastic_package_registry │ metrics     │ system    │ default   │ ERROR: failed to get deprecation warnings for data stream metrics-elastic_package_registry.metrics-62481: unexpected status code in response: [400 Bad Request] {"error":"no handler found for uri [/metrics-elastic_package_registry.metrics-62481/_migration/deprecations] and method [GET]"} │ 49.985708659s │
╰──────────────────────────┴─────────────┴───────────┴───────────┴─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┴───────────────╯

Author's checklist

  • Tested the changes running system tests with a Serverless project.
2025/04/03 18:16:47 TRACE Skip deprecation warnings in Serverless projects
2025/04/03 18:16:47 DEBUG Found 0 deprecation warnings for data stream metrics-elastic_package_registry.metrics-33382

@mrodm mrodm requested a review from a team April 3, 2025 16:22
@mrodm mrodm self-assigned this Apr 3, 2025
jsoriano
jsoriano approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mrodm mrodm merged commit 7884858 into elastic:main Apr 7, 2025
3 checks passed
@mrodm mrodm deleted the ignore-deprecation-warnings branch April 7, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees

@mrodm mrodm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mrodm @jsoriano